Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Extracts the constants previously embedded in the SolidJS telegram-setup-guide.tsx component into a new plain TypeScript file so that the test suite can import them without triggering Bun's JSX runtime resolution (which was attempting to resolve react/jsx-dev-runtime for the SolidJS component).
Changes:
- New
telegram-setup-guide-constants.tsholdsTELEGRAM_READINESS_CHECKS,TELEGRAM_GUIDE_COMMANDS,TELEGRAM_GUIDE_SECTIONS,TELEGRAM_GUIDE_TITLE, andTELEGRAM_GUIDE_REQUIRED_KEYS. telegram-setup-guide.tsximports the constants and re-exports them for backward compatibility.- The test file imports the constants from the new
.tsmodule instead of the.tsxcomponent.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app-prefixable/src/components/telegram-setup-guide-constants.ts | New module containing the extracted, JSX-free constants. |
| app-prefixable/src/components/telegram-setup-guide.tsx | Removes inline constants, imports from the new module, and re-exports them. |
| app-prefixable/tests/telegram-guide.test.tsx | Updates the import path to the new constants module to avoid JSX runtime resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tsfile to avoid importing JSX-containing modules in testsreact/jsx-dev-runtimeresolution errorCloses #397